Jump to content

Hit Delay Combat Bug Thread

Mead

By Mead
in General Discussion

 Share

Recommended Posts

  • Popular Post
Mead Newbie

Mead

Posted
  • Popular Post
Posted (edited)

Decided to show the current state of Roat Pkz 317 combat with another thread it'll be highlighting what is wrong and what needs to be fixed urgently.

Source: http://oldschoolrunescape.wikia.com/wiki/Hit_delay

 

Magic

 

Roat Pkz 317

 

On Current Roat Pkz 317 it takes 4 ticks from the point of casting on one square this is a bug because in these 4 ticks you can over eat food making for delayed combat where your waiting to be damaged but by the time you have been damaged by the 4 game tick delay it's too late to regenerate health.

As said before in the Hit Delay picture above it should be 1 sq distance = 2 game ticks (1.2 seconds).

 

OSRS

 

 

Game Code for Magic Hit Delay formula 

    if(c.usingMagic) {    // magic hit delay
                    int pX = c.getX();
                    int pY = c.getY();
                    int nX = Server.playerHandler.players.getX();
                    int nY = Server.playerHandler.players.getY();
                    int offX = (pY - nY)* -1;
                    int offY = (pX - nX)* -1;
                    c.castingMagic = true;
                    c.projectileStage = 2;
                    if(c.MAGIC_SPELLS[c.spellId][3] > 0) {
                        if(getStartGfxHeight() == 100) {
                            c.gfx100(c.MAGIC_SPELLS[c.spellId][3]);
                        } else {
                            c.gfx0(c.MAGIC_SPELLS[c.spellId][3]);
                        }
                    }
                    if(c.MAGIC_SPELLS[c.spellId][4] > 0) {
                        c.getPA().createPlayersProjectile(pX, pY, offX, offY, 50, 78, c.MAGIC_SPELLS[c.spellId][4], getStartHeight(), getEndHeight(), -i - 1, getStartDelay());
                    }
                    if (c.autocastId > 0) {
                        c.followId = c.playerIndex;
                        c.followDistance = 5;
                    }    
                    c.hitDelay = getHitDelay(c.getItems().getItemName(c.playerEquipment[c.playerWeapon]).toLowerCase());
                    c.oldPlayerIndex = i;
                    c.oldSpellId = c.spellId;
                    c.spellId = 0;
                    Client o = (Client)Server.playerHandler.players;
                    if(c.MAGIC_SPELLS[c.oldSpellId][0] == 12891 && o.isMoving) {
                        //c.sendMessage("Barrage projectile..");
                        c.getPA().createPlayersProjectile(pX, pY, offX, offY, 50, 85, 368, 25, 25, -i - 1, getStartDelay());
                    }
                    if(Misc.random(o.getCombat().mageDef()) > Misc.random(mageAtk())) {
                        c.magicFailed = true;
                    } else {
                        c.magicFailed = false;
                    }

     /**
    * Weapon and magic attack speed!
    **/
    
    public int getAttackDelay(String s) {
        if(c.usingMagic) {
            switch(c.MAGIC_SPELLS[c.spellId][0]) {
                case 12871: // ice blitz
                case 13023: // shadow barrage
                case 12891: // ice barrage
                return 5;
                
                default:
                return 5;

    /**
    * How long it takes to hit your enemy
    **/
    public int getHitDelay(String weaponName) {
        if(c.usingMagic) {
            switch(c.MAGIC_SPELLS[c.spellId][0]) {            
                case 12891:
                return 4;
                case 12871:
                return 6;
                default:
                return 4;
            }
        } else {

    }
    
    public int getRequiredDistance() {
        if (c.followId > 0 && c.freezeTimer <= 0 && !c.isMoving)
            return 2;
        else if(c.followId > 0 && c.freezeTimer <= 0 && c.isMoving) {
            return 3;
        } else {
            return 1;
        }

 

        Ranged         

 

Roat Pkz 317


Old code says It's 3 game ticks (1.8 seconds) Everywhere. When it should be 3 ticks for 3 sq's distance instead and 1 Distance should equal 2 ticks, (if PID applies it'll be one tick)

 

https://www.youtube.com/watch?v=-0H9XeNkiDs

 

 

Lets look at the Magic Short bow for an example taken from old source code

case 861: // magic short    
            c.usingBow = true;            
            c.bowSpecShot = 1;
            c.rangeItemUsed = c.playerEquipment[c.playerArrows];
            c.getItems().deleteArrow();    
            c.lastWeaponUsed = weapon;
            c.startAnimation(1074);
            c.hitDelay = 3;                                                                                = 3 game ticks 1.8 seconds. (No distances are included in the code)
            c.projectileStage = 1;
            c.specAccuracy = 1.50;
            c.hitDelay = getHitDelay(c.getItems().getItemName(c.playerEquipment[c.playerWeapon]).toLowerCase());
            if (c.fightMode == 2)
                c.attackTimer--;
            if (c.playerIndex > 0)
                fireProjectilePlayer();
            else if (c.npcIndex > 0)
                fireProjectileNpc();    
            break; 

 

Projectile Ranged

 

 

 

Melee

 

When casting barrage then using special (or any melee combat weapon) vs your opponent from one square you're able to stack hits because of the hit delay that roat pkz has this is wrong and nothing like OSRS it should only be via distance only:

 

 

Special Attack distance w/ Magic & Melee Hit delay bug

Result

 

 

Taking into account the distance Hit delay that OSRS uses on Roat Pkz it doesn't exist as it is has not been written into the code making for "unrealistic" enough combat that people on this server think is the norm, you're playing with obvious combat bugs that shouldn't be there and makes no sense making this server a "OSRS" server if  you can't get the fundamentals of a combat system right. 

Should focus on fixing your combat on the current game as these are very easy fixes to do for a pk server and can be fixed within 30 minutes and not 6 years.

 

 

 

Other Threads

 

Edited by Mead
  • Upvote 16
JBLIND Enthusiast

JBLIND

Posted
Posted

I like the thread, the reason why the combat is so off on here is coz the client is so fucking old. The new client which is literally about to come about will have this all fixed. SO WE HOPE

Happyaku Newbie

Happyaku

Posted
Posted

LMFAO at all the retards thinking a client is server sided. Timers = server sided. Client = looks. New client isnt saving shit retards

Do u even no java? should get hohgfohogfhoo ragger to teach u how to script

  • Upvote 2
Yoobs Newbie

Yoobs

Posted
Posted
2 hours ago, JBLIND™ said:

I like the thread, the reason why the combat is so off on here is coz the client is so fucking old. The new client which is literally about to come about will have this all fixed. SO WE HOPE

No it's not you delusional fuck?? It takes 5 seconds to change the formula server side, has absolutely no relevance to the client at all ??? It's because no-one ever bothered to implement any decent combat formula's on the game

  • Upvote 1
Happyaku Newbie

Happyaku

Posted
Posted (edited)
3 minutes ago, Yoobs said:

No it's not you delusional fuck?? It takes 5 seconds to change the formula server side, has absolutely no relevance to the client at all ??? It's because no-one ever bothered to implement any decent combat formula's on the game

even though u have autism it seems in this case u do not. How can people not understan  a client is only looks etc. Server sided = the code timers... etc how things work yet people think the client is noahs arc

Edited by Happyaku
  • Smackd locked and unlocked this topic
Mead Newbie

Mead

Posted
  • Author
Posted (edited)
On 7/11/2017 at 7:47 PM, Killbob said:

Roat is a private server if you want the real thing go play osrs also combat has been reworked for new client 

garbage server

Edited by Mead
Somalia Newbie

Somalia

Posted
Posted
25 minutes ago, Happyaku said:

So why is tom dwan got client? because he gave $9k? release the client since you're giving it away for free

Ask Salad for it and receive it. 

Getting access to it is easy, I think everybody has it by now except for you

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.

Guest
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

×
 Share
Go to topic listing
×
×
  • Create New...